Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording rule expression for kubelet status #948

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

weseven
Copy link
Contributor

@weseven weseven commented Nov 10, 2023

Added condition="Ready" label to kube_node_status_condition in raw_slo_requests recording rule expression since we only check that condition in the errors.

Without this the slo_error_per_request are 1/5 of the actual value, since the condition label has 5 possible values (Ready, DiskPressure, MemoryPressure, PIDPressure, NetworkUnavailable).


Towards: https://github.com/giantswarm/giantswarm/issues/27921#issuecomment-1804147257

Checklist

Added condition="Ready" label to kube_node_status_condition since we
only check that condition in the errors.
@weseven weseven requested a review from a team November 10, 2023 11:23
@weseven weseven requested a review from a team as a code owner November 10, 2023 11:23
@weseven weseven self-assigned this Nov 10, 2023
Copy link
Contributor

@whites11 whites11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@weseven weseven merged commit 665cba4 into master Nov 13, 2023
4 checks passed
@weseven weseven deleted the fix-node-condition-alert branch November 13, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants